-
Notifications
You must be signed in to change notification settings - Fork 2
feat(navbar): integrate Upbound unified navigation theme #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(navbar): integrate Upbound unified navigation theme #1060
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
668c62a to
9757d4a
Compare
9757d4a to
62544f9
Compare
62544f9 to
be8c638
Compare
be8c638 to
bf6b7be
Compare
- Add @upbound/elements package for consistent navbar components - Implement custom Navbar/Content with unified Upbound branding - Add session and feature flags providers for auth integration - Configure custom hooks (useFeatureFlags, useSessionHooks) - Update search bar styling to match unified theme - Add TypeScript configuration and type definitions
bf6b7be to
9951f2c
Compare
dechegaray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks pretty solid ! good separation of concerns, nice to see the reusability of many parts and the extensibility of docusaurus. All and all, 🚀 !!
|
|
||
| return ( | ||
| <OpenFeatureProvider> | ||
| <FeatureFlagGuard onError={onError} isContextLoaded={isContextLoaded}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice !! I forgot this was extracted to utils....useful stuff!
Description
❗ Not fully ready to be merged. Ahead of
docsprod deployment, we need to publish npm packages publicly.Type of change
Checklist
make lintlocally (or will fix Vale suggestions in review)Additional notes